-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Wheel pip regressions #656
Merged
nerdvegas
merged 14 commits into
AcademySoftwareFoundation:master
from
lambdaclan:fix/wheel-pip-regressions
Jul 10, 2019
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
02f37a7
fix(rez-pip): ensure the path to bin scripts works cross-platform
lambdaclan a629e50
fix(rez-pip): ensure only the bin scripts are set as tools
lambdaclan 28f5b8f
fix(rez-pip): correctly handle environment markers in requirements
lambdaclan d921e36
fix(rez-pip): ensure the pip version check warning is displayed
lambdaclan 2c3ee76
fix(rez-pip): fix typo and add link to environment markers
lambdaclan cc4248c
refactor(rez-pip): add os.sep to the bin check to avoid naming issues
lambdaclan 59fab19
refactor(rez-pip): use packaging instead of regex for version handling
lambdaclan 8be208f
feat(rez-pip): add attrs library (19.1.0) a packaging lib dependency
lambdaclan 0d35da7
feat(rez-pip): add packaging library to vendor packages
lambdaclan c6e1bba
feat(rez-pip): update the pydot (1.4.1) vendor package
lambdaclan bab2083
feat(rez-pip): update pyparsing package (2.4.0) to install packaging
lambdaclan 5d90580
feat(rez-pip): update six library (1.12.0) a packaging lib dependency
lambdaclan 5c44276
feat(rez-pip): add LICENSE file to distlib vendor package
lambdaclan de37814
fix(rez-pip): update vendor README file changes because of packaging lib
lambdaclan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(rez-pip): ensure only the bin scripts are set as tools
The current check if a file is executable or not seems to be causing some issues on Windows platform adding non executable files to the tools list in the package.py. Add a further check that ensures the executable script file is located in the bin folder. Relates: ef14e91
- Loading branch information
commit a629e508b9e82b9b908525d7271c06884d7443d9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"bin" + os.sep?