Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make _Miss iterable #726

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Sep 5, 2019

No description provided.

@maxnbk maxnbk added the topic:py3 Python 3 label Sep 5, 2019
@maxnbk maxnbk requested a review from nerdvegas September 5, 2019 21:22
@maxnbk maxnbk changed the title make _Miss iterable as assumed by ResolvedContext._packages_changed make _Miss iterable Sep 10, 2019
@nerdvegas
Copy link
Contributor

Closing as doesn't seem necessary (did old code require it?)

@nerdvegas nerdvegas closed this Sep 10, 2019
@maxnbk
Copy link
Contributor Author

maxnbk commented Oct 3, 2019

Reopening because I found the stack trace that was relevant for this.

Traceback (most recent call last):
  File "/rez/bin/rez/rez-env", line 8, in <module>
    sys.exit(run_rez_env())
  File "/rez/lib/python3.7/site-packages/rez/cli/_entry_points.py", line 152, in run_rez_env
    return run("env")
  File "/rez/lib/python3.7/site-packages/rez/cli/_main.py", line 152, in run
    returncode = run_cmd()
  File "/rez/lib/python3.7/site-packages/rez/cli/_main.py", line 144, in run_cmd
    return opts.func(opts, opts.parser, extra_arg_groups)
  File "/rez/lib/python3.7/site-packages/rez/cli/env.py", line 206, in command
    print_stats=opts.stats)
  File "/rez/lib/python3.7/site-packages/rez/resolved_context.py", line 282, in __init__
    resolver.solve()
  File "/rez/lib/python3.7/site-packages/rez/utils/memcached.py", line 249, in wrapper
    return func(*nargs, **kwargs)
  File "/rez/lib/python3.7/site-packages/rez/resolver.py", line 111, in solve
    solver_dict = self._get_cached_solve()
  File "/rez/lib/python3.7/site-packages/rez/resolver.py", line 298, in _get_cached_solve
    if _packages_changed(key, data) or _releases_since_solve(key, data):
  File "/rez/lib/python3.7/site-packages/rez/resolver.py", line 227, in _packages_changed
    solver_dict, _, variant_states_dict = data
TypeError: cannot unpack non-iterable _Miss object

@maxnbk maxnbk reopened this Oct 3, 2019
@nerdvegas nerdvegas mentioned this pull request Oct 4, 2019
@nerdvegas
Copy link
Contributor

Closing in favor of #755

@nerdvegas nerdvegas closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:py3 Python 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants