Skip test_build_cmake on Windows.
#772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should pass Windows after #770 |
The goal is to have better visibility of failure on Windows in our automated tests, while the CMake issues are being addressed. Added a known issues and limitations section in the README.
bfloch
force-pushed
the
feature/skip_windows_cmake_test
branch
from
5325395 to
5effe63
Compare
| @@ -155,6 +156,11 @@ def test_builds_anti(self): | |||
| @program_dependent("cmake") | |||
| def test_build_cmake(self): | |||
| """Test a cmake-based package.""" | |||
| if platform_.name == "windows": | |||
There was a problem hiding this comment.
I'm wondering if we could potentially do:
@unittest.skipIf(platform_.name == "windows", "This ...")
@program_dependent("cmake")
def test_build_cmake(self):
"""Test a cmake-based package."""Would that work?
There was a problem hiding this comment.
I'm merging this anyway, given that it's a temporary measure. If it works then it works - better to get traction on the source of the problem (and yes Blazej I will get up to speed on that ticket soon).
There was a problem hiding this comment.
Looks good @JeanChristopheMorinPerso.
I just took it from some other location that does it with a condition, so we might want to unify all of them.
But it's also true that we should try to get rid of these guys completely :)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to have better visibility of failure on Windows in our
automated tests, while the CMake issues are being addressed.
Added a known issues and limitations section in the README.