Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #927, add encoding=utf-8 on file write #928

Conversation

davidlatwe
Copy link
Contributor

This PR will allow installing/releasing packages which has Unicode character in package.py.

For example, this relaxing package "☺️" would failed before this PR

name = "_releaxed"

version = "0.1.0"

authors = ["☺️"]

build_command = False


def commands():
    print("Releax ! ☺️")

But after this PR, you get

C:\Users\david\dev\test\unicode-content>rez-build --install

================================================================================
Building _releaxed-a.b.c...
================================================================================
Resolving build environment:
resolved by david@DESKTOP-EABK8SP, on Mon Aug 10 02:34:17 2020, using Rez v2.63.0

requested packages:
~platform==windows           (implicit)
~arch==AMD64                 (implicit)
~os==windows-10.0.19041.SP0  (implicit)

resolved packages:

Invoking custom build system...

================================================================================
Build Summary
================================================================================

All 1 build(s) were successful.


C:\Users\david\dev\test\unicode-content>rez-env _releaxed
Releax ! ☺️

You are now in a rez-configured environment.

@nerdvegas nerdvegas merged commit 07deceb into AcademySoftwareFoundation:master Aug 11, 2020
@davidlatwe davidlatwe deleted the issue_927-unicode-pkg-install-failed branch August 25, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants