Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise unversioned error when config not allowed #938

Merged

Conversation

davidlatwe
Copy link
Contributor

Problem

When building unversioned package with config.allow_unversioned_packages = False, the error raised and says :

  ...
  File "..\rezplugins\package_repository\filesystem.py", line 715, in _create_variant
    overrides=overrides
  File "..\rezplugins\package_repository\filesystem.py", line 1228, in _create_variant
    raise RezSystemError("Internal failure - expected installed variant")
rez.exceptions.RezSystemError: Internal failure - expected installed variant

Which isn't clear enough to know that the failure was due to building a package which is unversioned while Rez has been configured to not allow it.

Propose

Check package data and config settings between data override applying and data dumping.
And the output would be :

Invoking custom build system...
20:48:55 ERROR    PackageMetadataError: Unversioned package is not allowed in current configuration.

@nerdvegas nerdvegas merged commit 4a2c837 into AcademySoftwareFoundation:master Aug 24, 2020
@nerdvegas
Copy link
Contributor

Thanks again for yet another concise and explanatory PR!

@davidlatwe davidlatwe deleted the raise-unversioned-error branch August 25, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants