Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored pydot (1.4.2.dev0) #970

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

davidlatwe
Copy link
Contributor

Problem

On Windows, when the Python is running from a Conda envirnoment, and Graphviz is NOT installed by Conda, dot executable will not be found. Because pydot changed to look for dot.bat if Conda environment is detected.

Solution

This is a rare case, and maybe even won't happen in production. But I was doing some tests with my IDE that has set to use Conda as virtual environment provider, so.. to avoid all those confusion in the future, I propose to update pydot which they already have a fix for this problem.

The problem cause: pydot/pydot-ng#52 L413-L417
The issue in pydot : pydot/pydot#205
The fix they made: pydot/pydot#237

Other changes they have made should not be a problem for Rez to accept. Only 4 commits after last update.

@maxnbk
Copy link
Contributor

maxnbk commented Nov 5, 2020

disclaimer, I have not looked at the commits yet, but please be aware we had to make some updates to the vendored pydot not to break imports when using py3 and during rez install steps, so it would be good to verify that the new vendored pydot is compatible in the same ways.

@davidlatwe
Copy link
Contributor Author

not to break imports when using py3 and during rez install steps

Hi, thanks to have a look. :)
And yep, checked that while I updating it.

@nerdvegas nerdvegas merged commit 88cb76c into AcademySoftwareFoundation:master Nov 16, 2020
@davidlatwe davidlatwe deleted the update-pydot branch November 17, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants