Update vendored pydot (1.4.2.dev0) #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, when the Python is running from a Conda envirnoment, and Graphviz is NOT installed by Conda,
dot
executable will not be found. Becausepydot
changed to look fordot.bat
if Conda environment is detected.Solution
This is a rare case, and maybe even won't happen in production. But I was doing some tests with my IDE that has set to use Conda as virtual environment provider, so.. to avoid all those confusion in the future, I propose to update
pydot
which they already have a fix for this problem.The problem cause: pydot/pydot-ng#52 L413-L417
The issue in pydot : pydot/pydot#205
The fix they made: pydot/pydot#237
Other changes they have made should not be a problem for Rez to accept. Only 4 commits after last update.