v0.9.28 #2334
Merged
v0.9.28 #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zjb0807
commented
Aug 31, 2022
•
zjb0807
commented
- Upgrade to v0.9.28 evm-tests#19
- Upgrade to v0.9.28 nutsfinance/stable-asset#32
|
blocked by paritytech/substrate#12297 |
xlc
approved these changes
Oct 1, 2022
shaunxw
approved these changes
Oct 2, 2022
| pub use futures::stream::StreamExt; | ||
| use jsonrpsee::RpcModule; | ||
| use sc_consensus::LongestChain; | ||
| use sc_consensus_aura::{ImportQueueParams, StartAuraParams}; | ||
| use sc_executor::WasmExecutor; | ||
| use sc_network::NetworkService; | ||
| use sc_network_common::service::NetworkBlock; |
There was a problem hiding this comment.
@zjb0807 could you please explain why this import is required here? and also in general when to use stuffs from sc-network-common?
There was a problem hiding this comment.
Remove and rebuild, you'll see some errors and suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.