Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvement for security #2343

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Some improvement for security #2343

merged 3 commits into from
Oct 6, 2022

Conversation

wangjj9219
Copy link
Member

  1. use wrapped function to issue/burn for some assets instead of using Tokens.deposit/withdraw directly
  2. config homa.LastEraBumpedBlock shouldn't cause immediately bump era

@wangjj9219 wangjj9219 marked this pull request as ready for review September 19, 2022 02:24
shaunxw
shaunxw approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlc xlc merged commit c021ce8 into master Oct 6, 2022
@xlc xlc deleted the some-improvement-for-security branch October 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunxw shaunxw shaunxw approved these changes

@xlc xlc Awaiting requested review from xlc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangjj9219 @shaunxw @xlc