Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows kkacz #45

Merged
merged 34 commits into from
Jul 21, 2023
Merged

Workflows kkacz #45

merged 34 commits into from
Jul 21, 2023

Conversation

krzysztofkaczorowski
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #45 (0111ad5) into workflows (73ed5e8) will not change coverage.
The diff coverage is n/a.

❗ Current head 0111ad5 differs from pull request most recent head 9b807d7. Consider uploading reports for the commit 9b807d7 to get more accurate results

@@             Coverage Diff              @@
##           workflows       #45    +/-   ##
============================================
  Coverage     100.00%   100.00%            
============================================
  Files             26        26            
  Lines            308       201   -107     
  Branches          17        17            
============================================
- Hits             308       201   -107
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@krzysztofkaczorowski krzysztofkaczorowski marked this pull request as draft July 19, 2023 16:07
@krzysztofkaczorowski krzysztofkaczorowski changed the base branch from master to workflows July 19, 2023 16:08
Krzysztof Kaczorowski added 2 commits July 19, 2023 18:25
@krzysztofkaczorowski krzysztofkaczorowski temporarily deployed to test July 20, 2023 05:17 — with GitHub Actions Inactive
@krzysztofkaczorowski krzysztofkaczorowski temporarily deployed to test July 20, 2023 05:28 — with GitHub Actions Inactive
@krzysztofkaczorowski krzysztofkaczorowski marked this pull request as ready for review July 20, 2023 05:32
piotrzajac
piotrzajac requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@piotrzajac piotrzajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please apply my comments.

piotrzajac
piotrzajac reviewed Jul 20, 2023
View reviewed changes
.github/workflows/cicd.yml Outdated
useConfigFile: true
- name: Fetch GitVersion
run: |
echo "Version=${{ steps.gitversion.outputs.MajorMinorPatch }}" >> $env:GITHUB_ENV
Copy link
Collaborator

@piotrzajac piotrzajac Jul 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume step Fetch GitVersion is not required anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed

@krzysztofkaczorowski krzysztofkaczorowski merged commit 05e23b6 into workflows Jul 21, 2023
@krzysztofkaczorowski krzysztofkaczorowski deleted the workflows_kkacz branch July 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrzajac piotrzajac piotrzajac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztofkaczorowski @piotrzajac