Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new objc2 crates #384

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Use new objc2 crates #384

merged 1 commit into from
Apr 25, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Apr 23, 2024

icrate has been split into multiple smaller crates, and the feature setup in that has been reworked, which should improve compilation times.

Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madsmtm, looks good!

I think we'll want to integrate this when we update to winit 1.30 though.

See rust-windowing/winit#3476

@mwcampbell
Copy link
Contributor

I see no reason to delay merging this. After all, our objc2 dependencies are already ahead of winit 0.29; this PR doesn't make it any worse. @DataTriny Do you disagree?

@DataTriny
Copy link
Member

Yes @mwcampbell you're right, no need to delay this. Sorry.

@DataTriny DataTriny merged commit b3484c0 into AccessKit:main Apr 25, 2024
10 checks passed
@mwcampbell mwcampbell mentioned this pull request Apr 23, 2024
@madsmtm madsmtm deleted the update-objc2 branch April 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants