Support agentOptions configuration for requests to CAS server #50
+167
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With previous version, tests would fail when comparing query
string values, as (for some reason), req.query would also contain
{__proto__: ""}, which would then then encoded into the URL.
This allows the same cert to be used for both cas and app server in the tests. But, it causes problems when the port is included, but doesn't match what the server is using. Create rootCA that can sign the request, allowing future work to specify the CA to trust when communicating with the CAS server for validations
All tests were updated to make the CAS server run using HTTPS and the cas configuration was updated to use the CA cert to verify it all works.
(Might it be time to consider updating the node_js version used in the travis builds??)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since CAS is such an important auth protocol, we want to make sure we trust the other end when making validations/working with proxy ticketing. In order to do that, we'd like to be able to specify
agentOptionson requests being made to the CAS server. Two use cases...NODE_TLS_REJECT_UNAUTHORIZED).Implementation
To implement, I added support for
agentOptionsto theconfigure()method, which defaults simply to{}and is passed along to all calls torequest.I also updated the test suite with new certs/keys that 1) don't include the port number in the CN and 2) are signed by a rootCA and updated the CAS servers to use them (it was speaking plain HTTP before). I included the csr and root CA key in case you want to reuse it or whatever. Totally up to you if you want to nuke those.
If you remove the setting of the
agentOptionsin allcas.configurecalls in the test suite, you'll see that they fail. I'm more than happy to add/consider other tests that should fit into this, if you can think of any others.