Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration window not displaying properly when adding a Lora #1343

Closed
DrFisura opened this issue Oct 30, 2024 · 3 comments
Closed

Configuration window not displaying properly when adding a Lora #1343

DrFisura opened this issue Oct 30, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@DrFisura
Copy link

First off, this wasn't an issue in previous versions of the plugin. Here's how it looks:

image

It expands way too much to the right when adding at least one lora with the default window size that always comes at launch, which forces me to expand the window manually every time so that I can see the weights to the right and change them. It used to be correctly formatted in previous versions, where the weights were visible without having to expand the window manually. Here's how it looks without a lora:

image

@Acly
Copy link
Owner

Acly commented Nov 2, 2024

Any idea what might cause it? Do you have Lora in the folder which may have a very long name (including subfolders) that would require this kind of space?

@DrFisura
Copy link
Author

DrFisura commented Nov 2, 2024

You have some pretty strong intuition for this; I recently added four loras with very large names, and as soon as I have removed them right now, and updated the lora list (within version 1.27.1) the window format has immediately corrected just like old.
So maybe it has nothing to do with the version after all, but I've checked and I've had a lora as long as 155 characters (including the .safetensors extension) without it breaking the window format. You might want to look into this further, but I'd consider it a low priority, if you want to do something about the window width having more options.

Also, I've just checked right now: if I put back in another lora with a 156 characters long name, the field expands a little already. I'm not sure if the individual character length has any bearing on this.

I can live with slightly shorter lora names; the reason they got that long anyway is because I add related character tags in them so that I could potentially copy them easily if I needed to, but I rarely do

Oh and thank you again for your work and the functionality of this plugin

@Acly Acly added the bug Something isn't working label Nov 4, 2024
@Acly
Copy link
Owner

Acly commented Nov 12, 2024

Fixed in v1.28.0

@Acly Acly closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants