Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoverability #74

Merged
merged 3 commits into from
Jul 27, 2015
Merged

Conversation

kosmotaur
Copy link
Contributor

Hi!

We've created a basic discover page. The use case is, that if we serve the blueprints on our internal network, and people visit its URL, it has been voiced that they could very much use a listing of all the endpoints exposed.

It is a bit rudimentary, and we plan on utilising Aglio to make it a beaut, but didn't want to introduce a dependency that big into Drakov. That's why the -D option accepts a string value, which would be the module to require to build the middleware to handle the discover page. We'll build that module separately.

Kind regards,
@SiCurious and @kosmotaur

@yakovkhalinsky
Copy link
Contributor

Very good! This is something I've been contemplating.

I'll have look over this over the next day 👍

@yakovkhalinsky
Copy link
Contributor

Just thinking we should probably use a reserved path for stuff like this. This also might be good because some users may want to specify / in their API specs.

For examples: http://localhost:3001/drakov which gives you access to the discovery API.

Would be handy to do this so we can then add more paths to this mount point for other functionality that represents drakov specific endpoints.

Let me know what you guys think.

ping @SiCurious @kosmotaur

@yakovkhalinsky
Copy link
Contributor

My other though was that it would be nice (maybe in another PR) to do /drakov?json and just return a JSON object with the endpoint information

@yakovkhalinsky
Copy link
Contributor

@SiCurious @kosmotaur I'm happy to merge this in and we'll change discovery endpoint to the reserved mount point of /drakov if that's cool with you guys

@SiAdcock
Copy link

Yeah, that makes sense to me. The JSON discoverability object is a great idea and would help with automated discovery.

@yakovkhalinsky yakovkhalinsky modified the milestone: 0.1.10 release Jul 26, 2015
@yakovkhalinsky
Copy link
Contributor

Merging now 👍

Will shortly update the routes to use the new reserved mount point of /drakov

Thanks again for the contribution guys 👍

yakovkhalinsky added a commit that referenced this pull request Jul 27, 2015
@yakovkhalinsky yakovkhalinsky merged commit 86d9238 into Aconex:master Jul 27, 2015
@yakovkhalinsky
Copy link
Contributor

discovery URL mount point changed in 2363cd5

@justingood justingood deleted the discoverability branch June 20, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants