Store ports in sockaddr_in structure in network byte order #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The structure sockaddr_in from netinet/in.h of stdlib declears that sin_port should be in network byte order. Switch from using host byte order to network byte order for the ports stored in the InetTuple.sockaddr_in.sin_port. Switch unit tests to expecting network byte order ports and use a non-symmetric test port to ensure byte order errors are detected.
carlatat
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure sockaddr_in from netinet/in.h of stdlib declears that sin_port should be in network byte order.
Switch from using host byte order to network byte order for the ports stored in the InetTuple.sockaddr_in.sin_port.
Switch unit tests to expecting network byte order ports and use a non-symmetric test port to ensure byte order errors are detected.