Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase 7] Complete Sharrow #611

Merged
merged 399 commits into from
Jan 3, 2023
Merged

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Sep 29, 2022

This PR supercedes all other sharrow PR's, and contains a complete and integrated implementation of all Phase 7 tasks.

Published (draft) documentation is here: https://camsys.github.io/activitysim/feature-sharrow-tt

@jpn-- jpn-- added this to the Phase 7 milestone Dec 13, 2022
Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I only have three comments.
I tested the placeholder_sandag multi-zone model with Sharrow on my windows machine, it ran fine.

.gitignore Show resolved Hide resolved
jpn-- and others added 7 commits January 2, 2023 09:06
Co-authored-by: Sijia Wang <wangsijia0628@gmail.com>
# Conflicts:
#	activitysim/cli/run.py
#	activitysim/core/memory_sidecar.py
#	activitysim/core/mp_tasks.py
@jpn-- jpn-- requested a review from i-am-sijia January 3, 2023 13:32
@jpn-- jpn-- merged commit 71d3e91 into ActivitySim:develop Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants