Fix for pandas 1.5 #629
Merged
Fix for pandas 1.5 #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pandas 1.5 there is a new
FutureWarningemitted when a column is set via iloc from an array of different dtype. In a future pandas, the update will eventually be done in-place. This is actually the preferred outcome for ActivitySim and no "real" code changes are needed. But some of our tests treat unexpected warnings as errors. To address this, we mark this particular warning as expected.Also, an upcoming Sharrow update will begin emitting
CacheMissWarningwhen the compiler needs to be invoked. This too is completely normal in some circumstances (including in many tests) so it too is marked as an expected warning.