Changes to support sharrow on 2-zone model #867
Conversation
…e/activitysim into trip_dest_alts_preprocess
| This is useful if you have tables in your OMX file that you don't want to | ||
| read in. For example, if you have both time-of-day values and time-independent | ||
| values (e.g., "BIKE_TIME" and "BIKE_TIME__AM"), you can ignore the time-of-day | ||
| values by setting this to ["BIKE_TIME__.+"]. |
There was a problem hiding this comment.
Is this required for sharrow? If so, I think we need to put an assert statement in the skim read for sharrow somewhere that will prevent this from happening and provide some info to the user about the error.
There was a problem hiding this comment.
Yes, not for sharrow per se, but the SkimDataset converts all the by-time-of-day skim variables into three dimensional arrays (o,d,time). So without this, in the example the OMX files essentially have two different sets of data for the same named variable, one two-dimension BIKE_TIME, and one three-dimension BIKE_TIME, which coincidentally happens to have no variance across the temporal dimension. We can't have two variables in the same namespace with the same name, so one is overwritten.
There was a problem hiding this comment.
Opened an issue #873 to address this.
…fix-all # Conflicts: # conda-environments/docbuild.yml # pyproject.toml
This PR has a number of changes made in support of sharrow on the new "canonical" 2-zone example, although as it turns out none of these changes really alter how ActivitySim runs...
land_use_columns_origsetting to aggregate accessibility, to allow joins against both destination (previously available) and origin (new) land use attributes without convoluted hacks in the spec.omx_ignore_patternstoState.settings, which allows us to ignore loading certain skim tables, either because they are problematic or just to save memory.sharrowto 2.9.1 (foromx_ignore_patterns) andnumbato 0.57 (to accessnp.nan_to_numas a numba function).joint_tour_frequency_compositionto correct math errors in the model spec.