Implemented ErrorBoundary component for cleaner error handling #99

ErikBjare · 2018-08-26T12:12:20Z

TODO

Doesn't work with async functions yet (i.e. most things that can go wrong in Activity.vue)
- Fixed by .catch(this.errorHandler) in the meantime
- Will hopefully be fixed by feat(errors): sync/async error handling for lifecycle hooks and v-on handlers (#7653, #6953) vuejs/vue#8395
- Someone wrote a hacky mixin that might work in the meantime: errorHandler not working in Promises / async vuejs/vue#7653 (comment)

ErikBjare added 2 commits August 26, 2018 14:08

added ErrorBoundary component and wrapped Activity view in it

7ca3442

added link to ErrorBoundary source

9534ab8

ghost assigned ErikBjare Aug 26, 2018

ghost added the review label Aug 26, 2018

ErikBjare added 2 commits August 28, 2018 13:14

Merge branch 'master' into dev/errorCaptured

0491ae3

fixed handling of errors without errorBoundary until it's properly fixed

4bf7839

ErikBjare requested a review from johan-bjareholt August 28, 2018 11:54

ErikBjare merged commit 73c783a into master Aug 28, 2018

ghost removed the review label Aug 28, 2018

ErikBjare deleted the dev/errorCaptured branch August 28, 2018 11:58