[faktory] Refactor image helper function #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcallewaert
force-pushed
the
override-imageregistry-busybox
branch
from
30a1991
to
7dfbecb
Compare
|
0.12.4 should be available momentarily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a refactor of the image helper function so it can be re-used for all containers for consistent behaviour:
global.imageRegistryfor all all containers.Our usecase is a kubernetes cluster configured without access to the public Docker registry, as a security measure. Instead, we rely exclusively on an internal mirror for pulling all images. We were unable to deploy the chart on this cluster as it was hardcoded to pull the busybox image from DockerHub.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[example]: Add service for feature xyz)