Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Pull Request #32

Open
wants to merge 53 commits into
base: rrs/master
Choose a base branch
from
Open

Final Pull Request #32

wants to merge 53 commits into from

Conversation

rileslovesyall
Copy link

Pull request for end of FarMar.

@rileslovesyall
Began writing specs for FarMar::Market initialize
4c054db
@rileslovesyall
Writing specs and code for Market self.all
8a80115
@rileslovesyall
working on basic specs and code
889ab6d
@rileslovesyall
Sales specs for .all still failing, moved over to Vendors, three spec…
b43b225 
…s failing
@rileslovesyall
Sale.rb fixed, tests running
369f1ce
@rileslovesyall
.all tests passing for Vendor
c2843c4
@rileslovesyall
Failing tests for product specs (#init, .all) written
916634c
@rileslovesyall
Product #initialize and .self tests passing.
390737e
@rileslovesyall
Changed the way I'm testing length of csv to length of array created …
f31e8eb 
…to make it better, hooray
@rileslovesyall
Fixed the find.all nonsense! Vendor specs passing
44440bc
@rileslovesyall
Market .find(id) method passing tests
42289c3
@rileslovesyall
Faled tests for Sale .find spec added
a8001f6
@rileslovesyall
Code written, spec fixed, test passing for Sale.find
0654dd9
@rileslovesyall
Spec for Product.find written and failing
cc4cc6f
@rileslovesyall
Product.find code written and passing tests
6795f3b
@rileslovesyall
Market.vendors specs written and failing
5b1e8d2
@rileslovesyall
Reworked specs slightly, code written and passing for Market.vendors
bc437e7
@rileslovesyall
Specs written and failing for Vendor.prodcuts()
92d99e8
@rileslovesyall
Vendor.products(id) passing tests
96aac56
@rileslovesyall
Vendor.sales specs written and failing
c696905
@rileslovesyall
Vendor.sales code wirrten and passing
77a2ffe
@rileslovesyall
Changed .all functions to use class variables, cutting down on test time
ca629ab
@rileslovesyall
Rewriting methods that i realize need to be instance not class
8867fa6
@rileslovesyall
Fixed Vendor.sales to #sales
4e360ef
@rileslovesyall
Fixed Market class methods that are now instance methods.
699ea90
@rileslovesyall
Vendor.by_market specs written and failing
970d72f
@rileslovesyall
revenue tests written adn failing
d4082ed
@rileslovesyall
Revenue code passing tests
eb2caea
@rileslovesyall
Product#vendor spec written and failing
4015f31
@rileslovesyall
Product#Vendor passing test
12f1c6d
@rileslovesyall
specs failing for Product#sales
907a3e8
@rileslovesyall
Product#sales passing tests
78267a6
@rileslovesyall
Product#number_of_sales tests failing
8917c76
@rileslovesyall
Product#number_of_sales passing tests, tests refactored
653514d
@rileslovesyall
Product.by_vendor(vendor_id) failing tests
7e00bab
@rileslovesyall
Product.by_vendor tests debugged, code written, tests passing
512ab53
@rileslovesyall
Sale#vendor spec written and failing
fa61bda
@rileslovesyall
Sale#vendor code passing
fbecfc2
@rileslovesyall
Sale#product passing tests
e191593
@rileslovesyall
Primary Requirements Complete, though code could probably use some re…
3d1293a 
…factoring and further testing. (At 100% but could test more side cases..)
@rileslovesyall
Market#products specs failing
7944a73
@rileslovesyall
Market#products code passing tests
370283f
@rileslovesyall
Tests for Market.search(search_term) written and failing
ddd7c51
@rileslovesyall
100% of code covered -- had to search for a term that was in a vendor…
d38ff08 
… in Market.search(search_term)
@rileslovesyall
Market#preferred_vendor code written and passing
51004d6
@rileslovesyall
Specs written for Market#worst_vendor
32ac0e5
@rileslovesyall
Market#worst_vendor code passing tests
bba5f14
@rileslovesyall
Specs written for Market#worst_vendor_by_date(date)
464b399
@rileslovesyall
Code written and passing for Market#worst_vendor_by_date(date)
a2e56f4
@rileslovesyall
Vendor.most_items code passing, Vendor.revenue(date) tests written an…
4067e40 
…d failing
@rileslovesyall
Changed the Market#preferred_vendor method to include both with and w…
3e15f2a 
…ithout date
@rileslovesyall
Commented out the Vendor.revenue(date) method because it is taking so…
be09d35 
… long I can't even run tests on it. May or may not have time to refactor before the project is due.
@rileslovesyall
Fixed the broken code yayyyyy
52f137f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rileslovesyall