MediaRanker by Becca #35
Conversation
…created welcome page shell.
…ded for index page for all media
| end | ||
|
|
||
| def show | ||
| @album = Album.find(params[:id]) |
There was a problem hiding this comment.
Since you repeat @album = Album.find(params[:id]) on several actions, you can use a before_action to set this and DRY up your code.
| <div class="col-lg-12"> | ||
| <h3>New Album</h3> | ||
|
|
||
| <%= form_for @album, url: {action: "create"}, html: {class: "form-group"} do |f| %> |
There was a problem hiding this comment.
As you mentioned, this would be a great place to use a partial :)
|
Nice job, @rmtolmach! In general, your code was clean and concise. As you mentioned, partials would've really helped to DRY up your code. It was good that you included tests for all of your controllers. There's still room for you to expand your tests -- confirming that |
I didn't worry about the difference in white space between mine and the sample. I didn't have any partials or anything fancy. I would like to have time to learn that stuff in the next applicable project.