Final submission for final wave of Media Ranker #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trowbrsa
changed the title
|
Bootstrap CSS and RSPEC tests completed, Wave 3 of project complete. |
| def movie_params | ||
| params.permit(movie: [:title, :director, :ranking, :description]) | ||
| end | ||
| end |
There was a problem hiding this comment.
Your initial setup of individual controllers for book, movie and albums are very clean. Nice.
|
@trowbrsa , awesome Media Ranker submission. Your spacing and styling is beautifully done and allows for easy to read clean coding. ( Pretty sure my code wasn't nearly this clean by now.) The conversion to one medium from three separate controllers indicates an strong grasp of concepts. Again, well done 👍 m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a few RSPEC tests I want to clean up and some light Boostrap updates to make. Please look for another pull request by Sunday evening (12/6/15).