MediaRanker #43
Open
MediaRanker #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at movie. Start work on the route to edit a movie
… page to navigate to the edit page, then back to the show page once a movie is edited.
…dex page into links to their respective show pages.
…and made a book model and seed data base for book model
…vie_upvote in order to have two distinct URL helpers
… layouts so that at any point the user has the option to click on the link to go back to the home page
…nt code coverage.
… percent code coverage.
…83 percent code coverage.
…ed route to named route in books controller. 87 percent code coverage.
…ercent code coverage.
…. 87 percent coverage.
…king on getting the book upvote test to pass. 98 percent code coverage.
| @@ -35,6 +36,8 @@ gem 'sdoc', '~> 0.4.0', group: :doc | |||
| group :development, :test do | |||
| # Call 'byebug' anywhere in the code to stop execution and get a debugger console | |||
| gem 'byebug' | |||
| gem 'rspec-rails' | |||
| gem 'simplecov' | |||
| end | |||
|
|
|||
| group :development do | |||
There was a problem hiding this comment.
Including only the gems you need, awesome! 👍 This is a good habit to have as the more dependencies you include the higher the change that your build will fail when deploying. I used to have the bad habit of copy pasta-ing gems from previous projects and it bit me at least once.
|
Great job overall! In the future make sure to use your before actions to your advantage (yay writing less code and removing duplication!) and cleanup any unused variables or methods. Other than that, take a moment to pat yourself on the back; your tests are solid, your test coverage is amazing and your code looks great! 🌟 If you have any questions about any of the comments I left or otherwise feel free to message me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have all functionality on the pages and 100% code coverage in rspec and I am still working on implementing bootstrap on some of the pages, but I have it on the index and show pages for books, albums, and movies.