MediaRanker baseline and some extensions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,47 +1,30 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I wouldn't worry about removing these comments. It shouldn't significantly affect performance and it's nice to have these explanations for those that're unfamiliar with these gems.
|
I'm really impressed! Your code is really clean and you take full advantage of Rail's magic without sacrificing legibility. 🎉🎉(I'm an advocate for clean/legible code so your project has made me super happy.) I also appreciated your attempt at using concerns. It's awesome that you recognized the repetitive code; I hope you get to use concerns in a future project, they seem pretty cool. Overall, fantastic work. I even learned a couple new things, so thanks! (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did the baseline
Refactored the controller rspec to have only one file shared amongst three controllers