Merge branch 'mr/trespeuch/vpcv2' into 'master'

Fix S3 Gateway endpoint route table IDs See merge request it/e3-aws!13
AdaCore · Oct 21, 2024 · 0db775e · 0db775e
2 parents 1351d2c + eec052d
commit 0db775e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/e3/aws/troposphere/ec2/__init__.py b/src/e3/aws/troposphere/ec2/__init__.py
@@ -911,8 +911,8 @@ def s3_gateway_endpoint(self) -> ec2.VPCEndpoint | None:
                 PolicyDocument=self.s3_endpoint_policy_document.as_dict,
                 # Attach the endpoints to all private subnets
                 RouteTableIds=[
-                    Ref(private_subnet)
-                    for private_subnet in self.private_subnets.values()
+                    Ref(private_subnet_rt)
+                    for private_subnet_rt in self.private_subnet_route_tables.values()
                 ],
                 ServiceName=f"com.amazonaws.{self.region}.s3",
                 VpcEndpointType="Gateway",

diff --git a/tests/tests_e3_aws/troposphere/ec2/vpc_v2_with_endpoints.json b/tests/tests_e3_aws/troposphere/ec2/vpc_v2_with_endpoints.json
@@ -393,10 +393,10 @@
             },
             "RouteTableIds": [
                 {
-                    "Ref": "TestVPCPrivateSubnetA"
+                    "Ref": "TestVPCPrivateRouteTableA"
                 },
                 {
-                    "Ref": "TestVPCPrivateSubnetB"
+                    "Ref": "TestVPCPrivateRouteTableB"
                 }
             ],
             "ServiceName": "com.amazonaws.eu-west-1.s3",