Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account several plan lines in context #294

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

enzbang
Copy link
Member

@enzbang enzbang commented Sep 9, 2019

plan_line attribute is reused to store several plan lines separated
by ';'. Long term solution would be to rename it plan_lines and to have
a tuple of plan lines.

For #293

plan_line attribute is reused to store several plan lines separated
by ';'. Long term solution would be to rename it plan_lines and to have
a tuple of plan lines.

For AdaCore#293
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #294 into e3transition will increase coverage by 0.81%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           e3transition     #294      +/-   ##
================================================
+ Coverage         89.09%   89.91%   +0.81%     
================================================
  Files                68       72       +4     
  Lines              4953     5491     +538     
================================================
+ Hits               4413     4937     +524     
- Misses              540      554      +14
Impacted Files Coverage Δ
e3/electrolyt/plan.py 99.17% <100%> (+0.01%) ⬆️
e3/os/platform.py 95.12% <0%> (-4.88%) ⬇️
e3/os/process.py 97.33% <0%> (-1.56%) ⬇️
e3/store/cache/backends/filecache.py 100% <0%> (ø) ⬆️
e3/os/fs.py 100% <0%> (ø) ⬆️
e3/os/timezone.py 100% <0%> (ø) ⬆️
e3/os/windows/process.py 100% <0%> (ø)
e3/os/windows/fs.py 100% <0%> (ø)
e3/os/windows/__init__.py 100% <0%> (ø)
e3/os/windows/native_api.py 100% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d2260...1a0226a. Read the comment docs.

@Nikokrock Nikokrock merged commit 93262a1 into AdaCore:e3transition Sep 17, 2019
@enzbang enzbang deleted the plan-lines-in-context branch June 23, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants