Add support for S3 bucket as source for anod #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of it/org/software-supply-chain/product-security/issues#24
grouigrokon
reviewed
Jan 18, 2024
grouigrokon
reviewed
Jan 18, 2024
enzbang
approved these changes
Jan 24, 2024
|
Note that there are some errors |
leocardao
requested changes
Mar 21, 2024
| @@ -20,6 +21,8 @@ | |||
| from collections.abc import Callable | |||
| from e3.mypy import assert_never | |||
|
|
|||
| SupportedVCS = Literal["git"] | Literal["svn"] | Literal["external"] | Literal["s3"] | |||
There was a problem hiding this comment.
You must use typing.Union. | is not supported for type aliasing.
| @@ -84,6 +87,8 @@ def update( | |||
| update = self.update_svn | |||
| elif vcs == "external": | |||
| update = self.update_external | |||
| elif vcs == "s3": | |||
| update = self.update_s3 | |||
| else: | |||
| assert_never() | |||
There was a problem hiding this comment.
This function takes one argument as parameter.
| """Update working dir using a S3 bucket as source. | ||
|
|
||
| :param url: s3 url to a s3 directory. s3://[profile@]bucket/suffix | ||
| :param revision: ignored |
There was a problem hiding this comment.
Why create an ignored parameter?
| # url validation | ||
| m = re.match("s3://([a-zA-Z0-9_-]+@)?(.+)$", url) | ||
| if m is None: | ||
| raise e3.error.E3Error("invalid s3 url: {url}") |
|
|
||
| # Extract profile from the url and perform basic | ||
| # url validation | ||
| m = re.match("s3://([a-zA-Z0-9_-]+@)?(.+)$", url) |
There was a problem hiding this comment.
Maybe should we compile this regex?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of it/org/software-supply-chain/product-security/issues#24