Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#252) Captcha queueing #253

Merged
merged 4 commits into from
Aug 3, 2019
Merged

Conversation

K1rakishou
Copy link

Closes #252

Fix a bug when after sending a reply via send button and then solving a captcha via the new captcha button the amount of valid token would not be updated.
Trim tokens in logs
@K1rakishou
Copy link
Author

Ready to be merged.

@Adamantcheese
Copy link
Owner

Alright, will do today or tomorrow.

@Adamantcheese
Copy link
Owner

Is there any particular reason why you've messed with ReplyLayout more than just adding in your authenticate button? Left is what it was originally, right is what it is now.
wut

@K1rakishou
Copy link
Author

K1rakishou commented Aug 2, 2019

What the hell. I only remember setting "tools:visibility="visible"" for every hidden view so it's more obvious what the layout looks like in the preview mode and adding my button. Looking at the layout now it's like completely different from what it was before. Maybe Ctrl+Alt+L somehow sorted the layout instead of just formatting it? In any case, this isn't intentional. Thanks for double-checking before merging.

@K1rakishou
Copy link
Author

K1rakishou commented Aug 2, 2019

Huh, for some reason when I press Ctrl+Alt+L to reformat the xml it fucking changes it's ordering completely. I usually press Ctrl+Alt+L all the time unconsciously so I didn't even notice that it has reordered the xml. Gotta be careful with this shit from now on.

Fix a little bug with notifiers not being notified sometimes.
@K1rakishou
Copy link
Author

Alright, the bug is fixed, layout reverted back so it can be merged.

@Adamantcheese Adamantcheese merged commit 2a2a893 into multi-feature Aug 3, 2019
@Adamantcheese
Copy link
Owner

Weird that reformat code messes up your formatting that much. I've got Ctrl + S mapped to a macro that reformats the current file and saves all open files, and I've never had it do that to me. Maybe you have a different code style set up that formats differently than default.

@K1rakishou
Copy link
Author

Well, I don't remember touching it at all. That's really strange.

@Adamantcheese
Copy link
Owner

Android Studio doing whatever it wants. Eh, whatever. Minor issue. Thanks for the quick fix.

@Adamantcheese Adamantcheese deleted the (#252)-captcha-queueing branch August 9, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Add ability to enter multiple captchas before posting, use entered captchas until they expire
2 participants