Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions windows build #71

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

Jacoby6000
Copy link
Contributor

@Jacoby6000 Jacoby6000 commented Oct 3, 2024

This sets up automated compilation/artifact generation for windows builds. I'll have a follow-up PR which will build on linux soon.

The primary benefit of this is having validation on every commit to master that the build works correctly, as well as having PRs automatically build and test the changeset.

You can see what this looks like on the PR I have in my repo here: Jacoby6000#1

  • Note the green checkmarks next to each commit hash
  • Each checkmark has an associated build and artifact that can be viewed. eg: 7572d29

You can see the built windows artifact for the commit/github actions run
And if set ENABLE_WINDOWS_RELEASES to true, you can have releases automatically attach a windows artifact, as seen in

Release artifacts are currently built when a release is published and ENABLE_WINDOWS_RELEASES is true I can change this behavior if you'd like.

Comment on lines +14 to +15
CEF_VERSION: '114.0.5735.199'
LUAJIT_VERSION: '2.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are changed, they will be downloaded/rebuilt as needed

@Adamcake Adamcake merged commit 69488f0 into Adamcake:master Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants