Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix download paths #2298

Merged
merged 2 commits into from
Nov 1, 2023
Merged

chore: fix download paths #2298

merged 2 commits into from
Nov 1, 2023

Conversation

sebmos
Copy link
Contributor

@sebmos sebmos commented Nov 1, 2023

No description provided.

sebmos
sebmos commented Nov 1, 2023
View reviewed changes
packages/client/install/README.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to Finsemble UAT (https://storage.googleapis.com/reactive-trader-finsemble-uat/pkg/ReactiveTraderFinsemble.exe) isn't right, either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, correct address is https://storage.googleapis.com/reactive-trader-finsemble-uat/pkg/ReactiveTraderFinsemble-UAT.exe .. you ok to update this commit?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

(auto-deploy) A deployment has been created for this Pull Request

Preview links

As part of the code review process, please ensure that you test against the following

Version URL
Web https://web.env.reactivetrader.com/pull/2298
OpenFin - FX fins://openfin.env.reactivetrader.com/pull/2298/config/rt-fx.json
OpenFin - Credit fins://openfin.env.reactivetrader.com/pull/2298/config/rt-credit.json
OpenFin - Launcher fins://openfin.env.reactivetrader.com/pull/2298/config/launcher.json
OpenFin - Workspace fins://openfin.env.reactivetrader.com/pull/2298/workspace/config/workspace.json
Finsemble https://finsemble.env.reactivetrader.com/pull/2298

Performance

Please ensure that this PR does not degrade the performance of the UI. We should maintain a performance score of 95+.

https://developers.google.com/speed/pagespeed/insights/?url=https://web.env.reactivetrader.com/pull/2298

algreasley
algreasley reviewed Nov 1, 2023
View reviewed changes
README.md Show resolved Hide resolved
packages/client/install/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, correct address is https://storage.googleapis.com/reactive-trader-finsemble-uat/pkg/ReactiveTraderFinsemble-UAT.exe .. you ok to update this commit?

@algreasley algreasley merged commit ae9d5d9 into master Nov 1, 2023
7 checks passed
@algreasley algreasley deleted the chore/readme-fix branch November 1, 2023 22:05
@algreasley
Copy link
Contributor

thanks @sebmos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algreasley algreasley algreasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebmos @algreasley