The selector for the allow button use the resourceId instead of the index #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @crgarridos ! Let me pass the tests on some devices I have around... :·D |
|
Nice, it works! Going to test it on emulators with all versions with runtime permissions: Android 23, 24, 25, 26... just to check that it works great :·) |
|
Let me share the results of the tests... Android 23: OK! 😄 Thanks for the work, @crgarridos ! |
rocboronat
reviewed
Jul 19, 2017
| @@ -17,7 +17,8 @@ | |||
| public class PermissionGranter { | |||
|
|
|||
| private static final int PERMISSIONS_DIALOG_DELAY = 3000; | |||
| private static final int GRANT_BUTTON_INDEX = 1; | |||
| private static final String PERMISSIONS_DIALOG_ALLOW_ID = "com.android.packageinstaller:id/permission_allow_button"; | |||
| // private static final String PERMISSIONS_DIALOG_DENY_ID = "com.android.packageinstaller:id/permission_deny_button"; | |||
There was a problem hiding this comment.
We will create another method that will use this ID to deny a permission. Thanks for it!
|
Great ! Thank to you for the awesome library :) |
alorma
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #108
Is the fist time I submit a pull request, hope I'm not messing up the things :s