Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update PermissionGranter to allow android 11 permissions #366

Merged
merged 9 commits into from
Sep 17, 2020
Merged

Feature: Update PermissionGranter to allow android 11 permissions #366

merged 9 commits into from
Sep 17, 2020

Conversation

alorma
Copy link
Member

@alorma alorma commented Sep 9, 2020

Updated permission granter to match ANY of the allow buttons in this order:

    "com.android.permissioncontroller:id/permission_allow_foreground_only_button",
    "com.android.permissioncontroller:id/permission_allow_button",
    "com.android.packageinstaller:id/permission_allow_button"

So we make sure that one of this buttons exists on the permission dialog.

Captura de pantalla 2020-09-09 a las 12 31 02

Also, added allowPermissionOneTime that accepts permission just this time, so we can do tests that involves multiple permission request time

One time permissions: https://developer.android.com/guide/topics/permissions/overview#one-time

@alorma alorma requested review from Sloy and a team September 9, 2020 10:33
@alorma alorma force-pushed the api11_permissions branch 4 times, most recently from fd93f80 to 758b31e Compare September 9, 2020 11:04
Sloy
Sloy previously approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@Sloy Sloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

library/src/main/java/com/schibsted/spain/barista/interaction/PermissionGranter.kt Show resolved Hide resolved
library/src/main/java/com/schibsted/spain/barista/interaction/PermissionGranter.kt Outdated Show resolved Hide resolved
sample/src/androidTest/java/com/schibsted/spain/barista/sample/PermissionGranterTest.kt Show resolved Hide resolved
@alorma alorma requested a review from Sloy September 17, 2020 06:19
Sloy
Sloy approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@Sloy Sloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alorma alorma merged commit e56d45e into master Sep 17, 2020
@alorma alorma deleted the api11_permissions branch September 17, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloy Sloy Sloy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alorma @Sloy