Assert view background with a plain color #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
approved these changes
Sep 30, 2020
| val viewDrawable = view.background as ColorDrawable | ||
| return viewDrawable.color == expectedDrawable.color && | ||
| viewDrawable.alpha == expectedDrawable.alpha && | ||
| viewDrawable.opacity == expectedDrawable.opacity |
There was a problem hiding this comment.
🤷 honestly, I started comparing the values that seemed important. But don't know the difference between alpha and opacity.
|
Thanks for the PR @rocboronat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #370
As @alorma pointed in a private secret messaging app that only we have, this solution doesn't take into account colors with states. Just plain colors. Red 🧧 Green 💚 Blue 📘
What do you think about merging this? IMHO, this PR is a small step forward ⏩
EXTRA, EXTRA! 📰 This is how Chrome renders the blue_car emoji: