Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BitmapComparator #435

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Simplify BitmapComparator #435

merged 2 commits into from
Aug 26, 2021

Conversation

Sloy
Copy link
Member

@Sloy Sloy commented Aug 26, 2021

This class was a compatibility workaround for old APIs. They are no longer supported, so the BitmapComparator is not useful anymore.

I replaced it with the native method.
I kept the test, but I moved it to the sample module because this was the only androidTest in the library module and it was affecting the build.

@Sloy Sloy requested review from etorralbo and alorma August 26, 2021 08:34
@Sloy
Copy link
Member Author

Sloy commented Aug 26, 2021

Before:
image

After:
image

@Sloy Sloy merged commit 864961b into master Aug 26, 2021
@Sloy Sloy deleted the simplify-bitmap-comparator branch August 26, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants