Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH: Use view model to load data #15

Merged
merged 4 commits into from
Feb 1, 2023
Merged

TECH: Use view model to load data #15

merged 4 commits into from
Feb 1, 2023

Conversation

alorma
Copy link
Member

@alorma alorma commented Feb 1, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Feb 1, 2023

  • Added new dependencies
  • Created a ViewModel to handle the data flow and lifecycle of the activity
  • Moved all logic from Activity into ViewModel, including menu handling (invalidateMenu)
  • Removed some unused code in TaggingViewerFilterListBottomSheetFragment that was not being used anymore after refactoring

@alorma alorma merged commit ee92555 into main Feb 1, 2023
@alorma alorma deleted the use_vioew_model branch February 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant