dnsforward: imp tests

AdguardTeam · Apr 24, 2024 · b71304a · b71304a
1 parent 3c42fca
commit b71304a
Showing 1 changed file with 24 additions and 6 deletions.
diff --git a/internal/dnsforward/beforerequest_internal_test.go b/internal/dnsforward/beforerequest_internal_test.go
@@ -99,10 +99,19 @@ func TestServer_HandleBefore_tls(t *testing.T) {
 		wantRCode:         dns.RcodeRefused,
 	}}
 
-	localRR := newRR(t, testFQDN, dns.TypeA, 3600, net.IP{1, 2, 3, 4})
+	localAns := []dns.RR{&dns.A{
+		Hdr: dns.RR_Header{
+			Name:     testFQDN,
+			Rrtype:   dns.TypeA,
+			Class:    dns.ClassINET,
+			Ttl:      3600,
+			Rdlength: 4,
+		},
+		A: net.IP{1, 2, 3, 4},
+	}}
 	localUpsHdlr := dns.HandlerFunc(func(w dns.ResponseWriter, req *dns.Msg) {
 		resp := (&dns.Msg{}).SetReply(req)
-		resp.Answer = []dns.RR{localRR}
+		resp.Answer = localAns
 
 		require.NoError(t, w.WriteMsg(resp))
 	})
@@ -147,7 +156,7 @@ func TestServer_HandleBefore_tls(t *testing.T) {
 
 			assert.Equal(t, tc.wantRCode, reply.Rcode)
 			if tc.wantRCode == dns.RcodeSuccess {
-				assert.NotEmpty(t, reply.Answer)
+				assert.Equal(t, localAns, reply.Answer)
 			} else {
 				assert.Empty(t, reply.Answer)
 			}
@@ -223,10 +232,19 @@ func TestServer_HandleBefore_udp(t *testing.T) {
 		wantTimeout:       true,
 	}}
 
-	localRR := newRR(t, testFQDN, dns.TypeA, 3600, net.IP{1, 2, 3, 4})
+	localAns := []dns.RR{&dns.A{
+		Hdr: dns.RR_Header{
+			Name:     testFQDN,
+			Rrtype:   dns.TypeA,
+			Class:    dns.ClassINET,
+			Ttl:      3600,
+			Rdlength: 4,
+		},
+		A: net.IP{1, 2, 3, 4},
+	}}
 	localUpsHdlr := dns.HandlerFunc(func(w dns.ResponseWriter, req *dns.Msg) {
 		resp := (&dns.Msg{}).SetReply(req)
-		resp.Answer = []dns.RR{localRR}
+		resp.Answer = localAns
 
 		require.NoError(t, w.WriteMsg(resp))
 	})
@@ -278,7 +296,7 @@ func TestServer_HandleBefore_udp(t *testing.T) {
 				require.NotNil(t, reply)
 
 				assert.Equal(t, dns.RcodeSuccess, reply.Rcode)
-				assert.NotEmpty(t, reply.Answer)
+				assert.Equal(t, localAns, reply.Answer)
 			}
 		})
 	}