Do not show 'port 443 is not available' error notification if encryption is not enabled

[rfgamaral]

Steps to reproduce

1. Install AdGuard Home on a system where port 443 is already in use.
2. Open AdGuard Home settings page.
3. Observe the red error notification with the message "Error: control/tls/validate | port 443 is not available, cannot enable HTTPS on it | 400".

Expected behavior

If "Enable Encryption" option is disabled, do not show any error notifications related to unavailable ports specified on this section.

Actual behavior

If "Enable Encryption" option is disabled, error notifications related to unavailable ports specified on this section are still shown even though the option is disabled and not being used.

Screenshot:

Your environment

Description	Value
Version of AdGuard Home server:	(e.g. v0.94)

[ameshkov]

@szolin this should be relatively easy to fix, assigned to v0.95

[EugeneOne1]

@Karmylr, yep.

[baoang]

AGH v0.107.3
Debian Buster
Nginx reverse proxy

Seems it still pops out the alert.

[baoang]

Version: v0.107.3, as shown at the bottom of the page.

…

On Wed, Feb 9, 2022 at 5:47 PM Eugene ***@***.***> wrote: @baoang <https://github.com/baoang>, what version of AdGuard Home are you using? — Reply to this email directly, view it on GitHub <#700 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECNHFLRKVY6YWVOYGSW4LDU2IZ2ZANCNFSM4HC72MJA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[mav808]

@EugeneOne1 I'm also getting this popup error on a fresh install of v0.107.3.

Edit: I edited the config to change the port to an available one, but since I wasn't using encryption it shouldn't have been checking the port in the first place.

[EugeneOne1]

@baoang, @mav808, we've been able to reproduce it, thanks. We'll fix it soon.

[ainar-g]

@IldarKamalov, can we please make sure that we don't send a validation request if encryption isn't enabled? Is there anything that prevents us from just doing that?

[baoang]

@baoang, @mav808, we've been able to reproduce it, thanks. We'll fix it soon.

My pleasure. Hope I can do more.

[ainar-g]

@baoang, we've recently released a fix for this on the edge channel. Could you please check if it works for you?

[ainar-g]

We'll close this issue for now. Please feel free to open a new one if there are new problems with that form.

[BenChueh]

hmm so which port should i forward from 443 to ?

[xliang76]

Looks like this still happening in v0.107.45

[Monoboy4ik]

hi!
have this too, adguard via docker on synology, built-in reverse-proxy on synology

and can't disable Plain DNS...