Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions with $important modifier in uBO filter lists are invalid #200

Closed
superlex opened this issue Nov 11, 2023 · 0 comments
Closed

Exceptions with $important modifier in uBO filter lists are invalid #200

superlex opened this issue Nov 11, 2023 · 0 comments
Assignees
@slavaleleka
Labels
Priority: P4 Resolution: Fixed Status: Closed

Comments

@superlex
Copy link

superlex commented Nov 11, 2023 •
edited
Loading

Unlike AdGuard, in uBO $important modifier applies only to network block filters:
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#important

FiltersCompiler should ignore them or remove $important modifier from these rules, otherwise they will be considered invalid.

Example:
@@||connectivitycheck.gstatic.com^$important
from
https://filters.adtidy.org/extension/ublock/filters/2_without_easylist.txt
@superlex superlex changed the title Ignore exceptions with $important modifier in uBO filter lists exceptions with $important modifier in uBO filter lists Nov 11, 2023
@superlex superlex changed the title exceptions with $important modifier in uBO filter lists Exceptions with $important modifier in uBO filter lists are invalid Nov 11, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Nov 22, 2023
slavaleleka added a commit to AdguardTeam/FiltersRegistry that referenced this issue Dec 6, 2023
@slavaleleka
skip unblocking important rules for ubo as unsupported
31122af 
AdguardTeam/FiltersCompiler#200
@slavaleleka slavaleleka mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Priority: P4 Resolution: Fixed Status: Closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@superlex @maximtop @adguard-bot @slavaleleka