Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use some redirects resources as scriptlets as well #300

Closed
AdamWr opened this issue Mar 21, 2023 · 2 comments
Closed

Use some redirects resources as scriptlets as well #300

AdamWr opened this issue Mar 21, 2023 · 2 comments
Assignees
@slavaleleka
Labels
Feature request Adding new feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10

Comments

@AdamWr
Copy link
Member

AdamWr commented Mar 21, 2023

It could be useful in some cases, for instance, when DNS filtering is enabled (request is blocked on DNS level, so it's not redirected) or $redirect modifier is not supported (extension for Safari, app for iOS).
For example here - AdguardTeam/AdguardFilters#146165
As I recall, also here - #184 (comment)
@slavaleleka
Copy link
Contributor

what exact redirects are needed as scriptlets?

@AdamWr
Copy link
Member Author

AdamWr commented Mar 21, 2023

I guess all these:
amazon-apstag
ati-smarttag
didomi-loader
fingerprintjs2
fingerprintjs3
gemius
google-analytics-ga
google-analytics
google-ima3
googlesyndication-adsbygoogle
googletagservices-gpt
matomo
metrika-yandex-tag
metrika-yandex-watch
naver-wcslog
pardot-1.0
prebid
scorecardresearch-beacon
could be useful.

@slavaleleka slavaleleka changed the title Add ability to use redirects resources as scriptlets Use some redirects resources as scriptlets as well Nov 2, 2023
@slavaleleka slavaleleka added the Feature request Adding new feature label Nov 2, 2023
@slavaleleka slavaleleka added the Feature request Adding new feature label Nov 2, 2023
adguard pushed a commit that referenced this issue Mar 12, 2024
@slavaleleka
add didomi-loader as scriptlet. #300 AG-27340
76b86ac 
Squashed commit of the following:

commit 70be56a
Merge: 14d9d3f 6709b30
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 18:15:10 2024 +0200

    Merge branch 'master' into feature/AG-27340-didomi-loader

commit 14d9d3f
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 16:20:40 2024 +0200

    fix changelog

commit a628157
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Mar 12 16:18:19 2024 +0200

    add didomi-loader as scriptlet
adguard pushed a commit that referenced this issue Mar 13, 2024
@slavaleleka
add both fingerprintjs as scriptlets. #300 AG-27340
bf78787 
Squashed commit of the following:

commit 5793922
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 11:26:11 2024 +0200

    AG-27340 add both fingerprintjs as scriptlets
adguard pushed a commit that referenced this issue Mar 13, 2024
@slavaleleka
add amazon-apstag as scriptlet. #300 AG-27340
b448648 
Squashed commit of the following:

commit 36a8fb1
Merge: fbf6253 0b3e540
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 12:22:26 2024 +0200

    Merge branch 'master' into feature/AG-27340-amazon-apstag

commit fbf6253
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 11:30:10 2024 +0200

    add amazon-apstag as scriptlet
adguard pushed a commit that referenced this issue Mar 13, 2024
@slavaleleka
add multiple google scriptlets. #300 AG-27340
aa07bef 
Squashed commit of the following:

commit ba81272
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 20:59:37 2024 +0200

    add multiple google scriptlets
adguard pushed a commit that referenced this issue Mar 13, 2024
@slavaleleka
add few metrika-yandex scriptlets. #300 AG-27340
121b30c 
Squashed commit of the following:

commit dee0888
Merge: 8262edb f9c29a6
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 21:12:32 2024 +0200

    merge master into the branch, resolve conflicts

commit 8262edb
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 21:08:23 2024 +0200

    add few metrika-yandex scriptlets
adguard pushed a commit that referenced this issue Mar 13, 2024
@slavaleleka
add naver-wcslog, pardot-1.0, prebid, and scorecardresearch-beacon as…
34ad54f 
… scriptlets.

#300 AG-27340

Squashed commit of the following:

commit bead118
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 22:43:06 2024 +0200

    add naver-wcslog, pardot-1.0, prebid, and scorecardresearch-beacon as scriptlets
adguard pushed a commit that referenced this issue Mar 14, 2024
@slavaleleka
add gemius and matomo as scriptlets, cleanup. #300 AG-27340
19d56b0 
Squashed commit of the following:

commit ed7a9db
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Mar 14 00:42:33 2024 +0200

    fix md linter

commit ed65b65
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 23:30:29 2024 +0200

    scan ts files for docs

commit 47c9b66
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Mar 13 23:25:44 2024 +0200

    add gemius and matomo as scriptlets, cleanup
This was referenced Apr 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Feature request Adding new feature Priority: P4 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximtop @AdamWr @adguard-bot @slavaleleka @stanislav-atr