-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'log-on-stack-trace' — player is broken on deltabit.co #384
Labels
bug
Something isn't working
Priority: P4
Release: v1.11.27
Resolution: Fixed
Status: Closed
Version: Scriptlets v1.11
Comments
Another steps to reproduce:
fiddle.jshell.net#%#//scriptlet('log-on-stack-trace', 'document.createElement')
Code:(()=> {
const re = /(\w+)\s(\w+)/;
const str = 'div a';
str.replace(re, '$2, $1');
document.createElement(RegExp.$1);
console.log(`RegExp.$1: ${RegExp.$1}`);
alert(`RegExp.$1: ${RegExp.$1}`);
})(); Alert
As far as I understand, the problem is that The same issue occurs with rule like this: fiddle.jshell.net#%#//scriptlet('abort-on-stack-trace', 'document.createElement', 'blablabla.whatever_test') but it works fine when regexp is used: fiddle.jshell.net#%#//scriptlet('abort-on-stack-trace', 'document.createElement', '/blablabla\.whatever_test/') |
adguard-bot
added
Status: In Progress
Resolution: Fixed
Status: In Review
and removed
Status: In Progress
labels
Aug 22, 2024
adguard-bot
changed the title
'log-on-stack-trace' breaks a player on deltabit.co
Fix 'log-on-stack-trace' — player is broken on deltabit.co
Aug 22, 2024
adguard
pushed a commit
that referenced
this issue
Aug 26, 2024
…trace` and `abort-on-stack-trace` scriptlets. #384 Squashed commit of the following: commit 0f6b357 Merge: 1ce19f2 aefd3da Author: Adam Wróblewski <adam@adguard.com> Date: Thu Aug 22 13:44:45 2024 +0200 Merge branch 'master' into fix/AG-28397 commit 1ce19f2 Author: Adam Wróblewski <adam@adguard.com> Date: Thu Aug 22 13:42:45 2024 +0200 Fix changelog Rename getRegexpValues to backupRegExpValues Rename setPreviousRegExpValues to restoreRegExpValues Log error Add test for backupRegExpValues commit 579b9d9 Author: Adam Wróblewski <adam@adguard.com> Date: Thu Aug 22 11:59:59 2024 +0200 Change null to void commit ecb91de Author: Adam Wróblewski <adam@adguard.com> Date: Thu Aug 22 10:55:31 2024 +0200 Fix issue with modifying `RegExp.$1` value in `log-on-stack-trace` and `abort-on-stack-trace` scriptlets
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Priority: P4
Release: v1.11.27
Resolution: Fixed
Status: Closed
Version: Scriptlets v1.11
AdGuard for Chrome 4.2.228
Steps to reproduce
deltabit.co#%#//scriptlet('log-on-stack-trace', 'document.createElement')
to user rulesActual behavior
The player is broken
Details
Reported by @ghajini
The text was updated successfully, but these errors were encountered: