Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trench decay fix, code cleanup & more #118

Merged
merged 6 commits into from
Feb 3, 2022

Conversation

johnb432
Copy link
Contributor

This PR includes a lot of minor code changes, but also some important fixes.

Fixed:

Changed:

  • (Medium) Code cleanup (comments, some simplifying of math, formatting).
  • (Minor) Usage of newer or/and faster commands (configOf, items).
  • (Personal preference) Steps for trench decay is now linear. When using low decay values, the trench decay seems to be somewhat odd with the current code.

Added:

  • (Minor) editorconfig file, for editorconfig https://editorconfig.org/.
  • (Minor) When cancelling a trench removal interaction, it resets the decay timer.

I have done some rudimentary testing - everything that was tested works as expected.

I can understand if you don't want various items proposed in here. I also apologize for the inconvenience this big PR will pose.
However please take a look at the 2 medium and major fixes which are by far the most important changes.

Copy link
Contributor

@Fusselwurm Fusselwurm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

havent tested functionality, but i love the cleanup ;)

@johnb432
Copy link
Contributor Author

https://github.com/gruppe-adler/grad_trenches/blob/7b4d29ac89094f87940c177188986d06108d507a/addons/functions/functions/fnc_continueDiggingTrench.sqf#L27
Is test_trench needed? I couldn't find it being referenced anywhere else. so I wanted to delete it, but forgot to - can easily push a commit to fix it if necessary.

.editorconfig Outdated Show resolved Hide resolved
@AdlerSalbei AdlerSalbei merged commit 5dedb65 into AdlerSalbei:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants