Trench decay fix, code cleanup & more #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a lot of minor code changes, but also some important fixes.
Fixed:
https://github.com/johnb432/grad_trenches/blob/34c54342c63b857aebd6fe645ef517cc8368d944/addons/functions/functions/fnc_decayPFH.sqf#L29
Previously this caused trenches to be removed, regardless if a player had interacted with it within the timeout or not.
https://github.com/johnb432/grad_trenches/blob/34c54342c63b857aebd6fe645ef517cc8368d944/addons/functions/functions/fnc_addDigger.sqf#L34
Changed:
Added:
I have done some rudimentary testing - everything that was tested works as expected.
I can understand if you don't want various items proposed in here. I also apologize for the inconvenience this big PR will pose.
However please take a look at the 2 medium and major fixes which are by far the most important changes.