-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune build cache after creating images #630
Conversation
Signed-off-by: Stewart X Addison <sxa@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR in the correct repo?
Jenkinsfile
Outdated
@@ -99,7 +99,7 @@ pipeline { | |||
def dockerBuild(version) { | |||
// dockerhub is the ID of the credentials stored in Jenkins | |||
docker.withRegistry('https://index.docker.io/v1/', 'dockerhub') { | |||
git poll: false, url: 'https://github.com/AdoptOpenJDK/openjdk-docker.git' | |||
git poll: false, url: 'https://github.com/sxa/openjdk-docker.git', branch: 'purge_cache' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should that be Adoptium?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - this is the container pushes for the adoptopenjdk dockerhub registry so it should be left as AdoptOpenJDK (we agreed to keep this active in a PMC meeting a couple of months back to keep them current for existing users who haven't yet updated) as we generally wouldn't want to have AdoptOpenJDK-badged stuff under github.com/adoptium. I'll need to adjust this after it's been approved, but at the moment if it's set to that in order to pull from my branch to be able to test it.
I've reverted this line so it's correct, but it means that the problem resolved by this PR will now recur unless this is merged quickly. Hopefully we can get it in today.
Signed-off-by: Stewart X Addison <sxa@redhat.com>
It looks likethe checks that are stuck are the windows 2016 ones:
On the basis that this shouldn't cause any additional problems and has been tested in the jenkins job (albeit not for windows) I'm just going to merge this. |
This will resolve the ever expanding docker cache on some of the machines which is ultimately chewing up all of the disk space in
/var/lib/docker
Fixes adoptium/infrastructure#3007
(Note that the https://ci.adoptium.net/job/openjdk_build_docker_multiarch/ job is currently set to run from my branch for testing and will need to be switched back after this is merged, as I don't really want it running from the branch!)