Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move strings out to a config file #2

Closed
VermaSh opened this issue Mar 15, 2018 · 2 comments
Closed

Move strings out to a config file #2

VermaSh opened this issue Mar 15, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@VermaSh
Copy link
Contributor

VermaSh commented Mar 15, 2018 •
edited
Loading

It would be nice to have all the hard coded strings, such as the ones one for labels sw.os., hw., slave jar location for command launcher, in a constants/config file. This would make the api easier to maintain.
@VermaSh VermaSh mentioned this issue Mar 15, 2018
Merged
@VermaSh VermaSh added the enhancement New feature or request label Mar 28, 2018
@VermaSh
Copy link
Contributor Author

VermaSh commented Mar 29, 2018

Update:

  • Have created a Constants.groovy file in vars folder
  • So far, only the strings used by CreateNewNode job has been moved to this file

TODO:

VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 5, 2018
@VermaSh
Improvement
f44b484 
- Added node labels based, as discussed in adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh
Copy link
Contributor Author

VermaSh commented Apr 6, 2018

Update:

  • Extracted out the node labels to the vars/Constants.groovy. Need to run a few tests before it's ready to be merged in

@VermaSh VermaSh mentioned this issue Apr 9, 2018
Merged
VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 10, 2018
@VermaSh
Improvement
9964104 
- Added node labels based, as discussed in adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 11, 2018
@VermaSh
Extracted label strings to Constants file
a950325 
- Modified the API to use label strings from Constants.groovy
- Added setDescription function

issue adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 11, 2018
@VermaSh
Extracted label strings to Constants file
ac19260 
- Modified the API to use label strings from Constants.groovy
- Added setDescription function

issue adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 11, 2018
@VermaSh
Extracted label strings to Constants file
5529631 
- Modified the API to use label strings from Constants.groovy
- Added setDescription function

issue adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
AdamBrousseau pushed a commit that referenced this issue Apr 11, 2018
@VermaSh @AdamBrousseau
Node helper api (#17)
d70d8eb 
* Extracted label strings to Constants file

- Modified the API to use label strings from Constants.groovy
- Added setDescription function

issue #2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh added a commit to VermaSh/openjdk-jenkins-helper that referenced this issue Apr 11, 2018
@VermaSh
Extracted label strings to Constants file
8994913 
- Modified the API to use label strings from Constants.groovy
- Added setDescription function

issue adoptium#2

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdamBrousseau @VermaSh