Node helper api #17
Merged
Node helper api #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VermaSh
force-pushed
the
NodeHelperAPI
branch
3 times, most recently
from
c655d37 to
1bf285e
Compare
AdamBrousseau
suggested changes
Apr 11, 2018
- Modified the API to use label strings from Constants.groovy - Added setDescription function issue adoptium#2 Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
- Modified the API to use label strings from Constants.groovy - Added setDescription function issue adoptium#2 Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
AdamBrousseau
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have extracted the strings for labels to a separate file, Constants.groovy. This will allows easy modification of the label format if the standard changes in the future.
This addresses the issue number 2, Move Strings out to a config file