Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Siri and shortcuts support #127

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

EmersonCarpes
Copy link
Contributor

What did you change:

  • Adding Siri support for commands "Listen Sabbath School" and "Read Sabbath School"
  • Adding shortcuts "Listen Sabbath School" and "Read Sabbath School"
  • Implementing Siri Donation Shortcuts

Merge checklist

  • Automated (unit/ui) tests
  • Manual tests

@VitalikL
Copy link
Member

Great! @EmersonCarpes Can you please attach video / gif of showing how it works. Also, what do you mean by "Donation shortcuts"?

@EmersonCarpes
Copy link
Contributor Author

@VitalikL sure! About donations below a description how it works...

Siri can predict shortcuts to actions that a user may want to perform using your app, and suggest those shortcuts to the user in places such as Spotlight search, Lock Screen, and the Siri watch face. Siri learns about the shortcuts available for your app through donations that your app makes to Siri. Users can also use donated shortcuts to add personalized voice phrases to Siri.

https://developer.apple.com/documentation/sirikit/donating_shortcuts

@@ -2627,7 +2655,7 @@
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 1002;
DEVELOPMENT_TEAM = XVGX5G4YQ9;
ENABLE_BITCODE = YES;
ENABLE_BITCODE = NO;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious on why did you had to disable bitcode? Is possible to work around it?

Copy link
Contributor Author

@EmersonCarpes EmersonCarpes Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been deprecated with Xcode 14

https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL... I guess it's good then 😅

intent: ListenTodaySabbathSchoolIntent(),
phrases: [
"Listen \(.applicationName)",
"Play \(.applicationName)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the phases be localized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not localized yet because I'm not really sure about commands yet

@EmersonCarpes EmersonCarpes marked this pull request as draft January 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants