-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Siri and shortcuts support #127
base: develop
Are you sure you want to change the base?
Conversation
Great! @EmersonCarpes Can you please attach video / gif of showing how it works. Also, what do you mean by "Donation shortcuts"? |
@VitalikL sure! About donations below a description how it works...
https://developer.apple.com/documentation/sirikit/donating_shortcuts |
@@ -2627,7 +2655,7 @@ | |||
CODE_SIGN_STYLE = Manual; | |||
CURRENT_PROJECT_VERSION = 1002; | |||
DEVELOPMENT_TEAM = XVGX5G4YQ9; | |||
ENABLE_BITCODE = YES; | |||
ENABLE_BITCODE = NO; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious on why did you had to disable bitcode? Is possible to work around it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been deprecated with Xcode 14
https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes
Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL... I guess it's good then 😅
intent: ListenTodaySabbathSchoolIntent(), | ||
phrases: [ | ||
"Listen \(.applicationName)", | ||
"Play \(.applicationName)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the phases be localized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not localized yet because I'm not really sure about commands yet
What did you change:
Merge checklist