Add comment to explain LayoutInflater problem

COAND-806
Adyen · May 22, 2024 · 604abd9 · 604abd9
1 parent d1ed1a0
commit 604abd9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/...ore/src/main/java/com/adyen/checkout/components/core/internal/util/StatusResponseUtils.kt b/...ore/src/main/java/com/adyen/checkout/components/core/internal/util/StatusResponseUtils.kt
@@ -21,8 +21,4 @@ object StatusResponseUtils {
     fun isFinalResult(statusResponse: StatusResponse): Boolean {
         return RESULT_PENDING != statusResponse.resultCode
     }
-
-    fun isPendingResult(statusResponse: StatusResponse): Boolean {
-        return RESULT_PENDING == statusResponse.resultCode
-    }
 }
diff --git a/twint/src/main/java/com/adyen/checkout/twint/internal/ui/DefaultTwintDelegate.kt b/twint/src/main/java/com/adyen/checkout/twint/internal/ui/DefaultTwintDelegate.kt
@@ -83,10 +83,7 @@ internal class DefaultTwintDelegate(
 
     private fun restoreState() {
         adyenLog(AdyenLogLevel.DEBUG) { "Restoring state" }
-        val action: SdkAction<TwintSdkData>? = action
-        if (action != null) {
-            initState(action)
-        }
+        action?.let { initState(it) }
     }
 
     override fun observe(

diff --git a/twint/src/main/java/com/adyen/checkout/twint/internal/ui/TwintFragment.kt b/twint/src/main/java/com/adyen/checkout/twint/internal/ui/TwintFragment.kt
@@ -33,7 +33,7 @@ internal class TwintFragment : Fragment() {
 
     private var twint: Twint? = Twint(this, ::onTwintResult)
 
-    private var twintResultQueue: TwintPayResult? = null
+    private var queuedTwintResult: TwintPayResult? = null
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
         _binding = FragmentTwintBinding.inflate(inflater, container, false)
@@ -50,7 +50,7 @@ internal class TwintFragment : Fragment() {
             .onEach { twint?.payWithCode(it) }
             .launchIn(viewLifecycleOwner.lifecycleScope)
 
-        twintResultQueue?.let {
+        queuedTwintResult?.let {
             adyenLog(AdyenLogLevel.DEBUG) { "initialize: executing queue" }
             onTwintResult(it)
         }
@@ -62,10 +62,10 @@ internal class TwintFragment : Fragment() {
             ?.handleTwintResult(result)
             ?.also {
                 adyenLog(AdyenLogLevel.DEBUG) { "onTwintResult: clearing queue" }
-                twintResultQueue = null
+                queuedTwintResult = null
             } ?: run {
             adyenLog(AdyenLogLevel.DEBUG) { "onTwintResult: setting queue" }
-            twintResultQueue = result
+            queuedTwintResult = result
         }
     }
 

diff --git a/ui-core/src/main/java/com/adyen/checkout/ui/core/AdyenComponentView.kt b/ui-core/src/main/java/com/adyen/checkout/ui/core/AdyenComponentView.kt
@@ -157,6 +157,11 @@ class AdyenComponentView @JvmOverloads constructor(
         }
     }
 
+    /**
+     * Returns the [LayoutInflater] of the parent activity or fragment. Using `LayoutInflater.from(context)` when the
+     * view's parent is a fragment will return the [LayoutInflater] of the fragment's activity. This causes issues with
+     * nested fragment's.
+     */
     @Suppress("SwallowedException")
     private fun getLayoutInflater(): LayoutInflater = try {
         findFragment<Fragment>().layoutInflater