Restore action handling state #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozgur00
reviewed
Mar 4, 2024
...ore/src/main/java/com/adyen/checkout/action/core/internal/ui/DefaultGenericActionDelegate.kt
Outdated
Show resolved
Hide resolved
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
from
d7bdf34
to
8b279fc
Compare
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
2 times, most recently
from
e878977
to
5ddaef7
Compare
ozgur00
previously approved these changes
Mar 21, 2024
|
Let's wait a bit with merging this one |
jreij
reviewed
Apr 3, 2024
...ore/src/main/java/com/adyen/checkout/action/core/internal/ui/DefaultGenericActionDelegate.kt
Outdated
Show resolved
Hide resolved
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
from
3792d7c
to
18c010b
Compare
|
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
3 times, most recently
from
24c44f1
to
4c1ab54
Compare
jreij
reviewed
May 15, 2024
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
2 times, most recently
from
c884fef
to
055d93f
Compare
COAND-857
COAND-857
COAND-857
COAND-857
The specific action delegates should do this since they share a SavedStateHandle and are also responsible for removing it. COAND-857
…rCodeDelegate COAND-857
Not for 3ds2 and WeChat though, because they are too specific. COAND-857
OscarSpruit
force-pushed
the
fix/restore-action-handling-state
branch
from
055d93f
to
ce91061
Compare
|
ozgur00
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When launching a redirect in the browser, the merchant app could be killed by the system. Finishing the redirect in that case would fail, because the state was lost. With these changes we can restore the state and finish the payment.
Checklist
COAND-857