-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor example app build config keys #1505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreij
force-pushed
the
refactor/example_app_secrets
branch
2 times, most recently
from
March 8, 2024 13:20
cbb08ae
to
0fe89b2
Compare
1 task
This was
linked to
issues
Mar 8, 2024
Closed
OscarSpruit
force-pushed
the
refactor/example_app_secrets
branch
2 times, most recently
from
March 8, 2024 15:39
bd1bfdc
to
ddb206d
Compare
example-app/src/main/java/com/adyen/checkout/example/ui/configuration/ConfigurationActivity.kt
Show resolved
Hide resolved
araratthehero
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
jreij
commented
Mar 11, 2024
jreij
commented
Mar 11, 2024
jreij
commented
Mar 11, 2024
OscarSpruit
force-pushed
the
refactor/example_app_secrets
branch
from
March 11, 2024 14:08
ddb206d
to
f2ea831
Compare
This forces merchants to copy the default.local.gradle file and replace the placeholders with the actual values COAND-831
To make it more generic and not explicitly encourage people to use their API keys COAND-831
…lue to settings COAND-831
COAND-831
OscarSpruit
force-pushed
the
refactor/example_app_secrets
branch
from
March 11, 2024 14:08
f2ea831
to
0b8aa4b
Compare
Quality Gate passedIssues Measures |
@OscarSpruit all good from my side but I can't approve my own PR 😅 If you are happy with my changes from the first 7 commits please approve. |
araratthehero
approved these changes
Mar 11, 2024
OscarSpruit
approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to the example app build config (related to #1486):
default.local.gradle
toexample.local.gradle
.example.local.gradle
file is copied and its placeholders are replaced with the actual values.API_KEY
toAUTHORIZATION_HEADER
and redact it from logs.How to migrate
If you already had set up the example app, this PR will cause your build to fail. To migrate go to
example-app/local.gradle
and follow these steps:API_KEY_HEADER_NAME
toAUTHORIZATION_HEADER_NAME
.CHECKOUT_API_KEY
toAUTHORIZATION_HEADER_VALUE
.SHOPPER_REFERENCE
line. It will now default to"test-android-components"
, you can change that value in the settings screen if you want."\"SOME_VALUE\""
can be replaced with'"SOME_VALUE"'
.Checklist
COAND-831