Support changing the custom tabs toolbar and navigation colors #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarSpruit
reviewed
May 14, 2024
ui-core/src/main/java/com/adyen/checkout/ui/core/internal/util/CustomTabsLauncher.kt
Show resolved
Hide resolved
| <attr name="adyenStrokeColor" format="color" /> | ||
| </declare-styleable> | ||
|
|
||
| <declare-styleable name="AdyenCheckoutCustomTabs"> |
There was a problem hiding this comment.
Isn't this name supposed to be the same as a custom view? And since we don't have a view, is it necessary to declare a styleable?
There was a problem hiding this comment.
You're right I missed that, can you check the latest commit?
jreij
force-pushed
the
feature/custom-tabs-styling
branch
from
7d9dc10
to
4b348a9
Compare
|
OscarSpruit
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we directly use
colorPrimaryas the toolbar color for our custom tabs where we launch external redirects. This PR allows changing this color as well as 3 other customizable colors (toolbarColor,secondaryToolbarColor,navigationBarColorandnavigationBarDividerColor).To preserve consistency with custom styling across the library, we added an XML style that can be overridden and will be applied internally to the custom tabs. This also allows easily setting different light and dark theme colors.
Checklist
COAND-907