Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop-in unable to handle 3DS2 on API v66 and below #1629

Merged
merged 2 commits into from
May 14, 2024

Conversation

jreij
Copy link
Collaborator

@jreij jreij commented May 14, 2024

Description

With Checkout API v66 and earlier, drop-in throws an error while trying to handle two separate 3DS2 actions returned by the API (fingerprint and challenge).

Checklist

  • PR is labelled
  • Changes are tested manually
  • Related issues are linked

COAND-906

jreij added 2 commits May 14, 2024 10:21
…tive actions

This is only applicable for 3DS2 with API v66 and before, where the payments call return one action (fingerprint) then the details call returns another action (challenge) both of which need to be handled with the same component
COAND-906
@jreij jreij added the Fix [PRs only] Indicates a bug fix label May 14, 2024
@jreij jreij requested a review from a team as a code owner May 14, 2024 08:24
Copy link
Contributor

@OscarSpruit OscarSpruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This fixes an issue I was running into in the state PR

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jreij jreij merged commit 10cc7e4 into develop May 14, 2024
8 checks passed
@jreij jreij deleted the fix/old-3ds2-flow-drop-in branch May 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants